infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

New template and options for Service-Based-View #61

Merged
zuul merged 15 commits from template_sbv into main 2023-04-20 13:10:19 +00:00
Conversation 13 Commits 15 Files Changed 5 +96 -1
5 changed files with 96 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b9d73eb441 - Show all commits

9
tools/generate_doc_confpy.py
View File

@ -329,12 +329,19 @@ def main():
parser.add_argument( parser.add_argument(
"--overwrite-index-sbv", "--overwrite-index-sbv",
action="store_true", action="store_true",
help="Whether to overwrite index.rst for service-based-view" help=("Whether to overwrite index.rst for service-based-view."
sgode marked this conversation as resolved
vhasko commented 2023-04-18 17:55:12 +00:00
Review
Copy Link

I think it should be somewhere mentioned that this parameter can be used only in combination with update_sbv

I think it should be somewhere mentioned that this parameter can be used only in combination with update_sbv
sgode commented 2023-04-20 07:17:52 +00:00
Review
Copy Link

I have added a better description and error handling for that case.

I have added a better description and error handling for that case.
+ "\nCan only be used if --update-sbv is also specified")
) )
args = parser.parse_args() args = parser.parse_args()
logging.basicConfig(level=logging.DEBUG) logging.basicConfig(level=logging.DEBUG)
services = [] services = []
if args.overwrite_index_sbv and not args.update_sbv:
logging.error(
"Cannot overwrite index.rst for service-based-view"
+ " without updating service-based-view"
)
exit(1)
if args.service_type: if args.service_type:
services = [data.service_dict.get(args.service_type)] services = [data.service_dict.get(args.service_type)]
else: else: