infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

Added sphinx-minify to tox #147

Merged
zuul merged 3 commits from minify-template-tox into main 2023-11-01 13:29:43 +00:00
Conversation 7 Commits 3 Files Changed 2 +10 -23
sgode commented 2023-10-16 12:34:53 +00:00
Owner
Copy Link
sgode added 1 commit 2023-10-16 12:34:53 +00:00
Added sphinx-minify to tox
All checks were successful
gl/check check status: success (7f96f3f1b4166a9bae255d70a776d7f6ebe9e28e)
Details
7f96f3f1b4
zuul commented 2023-10-16 12:37:43 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/50b8c4cd60c14c218c87199897869a9d

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/50b8c4cd60c14c218c87199897869a9d - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/5af3727d26204a4aae84a6767680dce1): SUCCESS in 2m 09s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/3c34fb4e5f3349268f1dcf50926c4ea4): SUCCESS in 2m 22s
sgode requested review from vhasko 2023-10-16 12:53:45 +00:00
sgode requested review from tischrei 2023-10-16 12:53:45 +00:00
tischrei approved these changes 2023-10-16 13:10:53 +00:00
vhasko reviewed 2023-10-20 13:30:52 +00:00
otc_metadata/templates/tox.ini.j2 Outdated
@ -69,2 +70,3 @@
sphinx-build -W --keep-going -b html {{ loc }}/source doc/build/html/{{ doc.type }}
sphinx-build -W --keep-going -b html {{ loc }}/source doc/build/html_temp/{{ doc.type }}
{%- if doc.type == 'api-ref' %}
sphinx-minify --input-directory doc/build/html_temp/api-ref --output-directory doc/build/html/api-ref
vhasko commented 2023-10-20 13:30:37 +00:00
Owner
Copy Link

in this case I don’t see any reason why you duplicating this entry in to 3 condition cases instead of putting it before condition and parametrizing it with doc.type like:

sphinx-minify --input-directory doc/build/html_temp/{{ doc.type }} --output-directory doc/build/html/{{ doc.type }}
in this case I don't see any reason why you duplicating this entry in to 3 condition cases instead of putting it before condition and parametrizing it with doc.type like: ``` sphinx-minify --input-directory doc/build/html_temp/{{ doc.type }} --output-directory doc/build/html/{{ doc.type }} ```
sgode commented 2023-10-24 07:57:00 +00:00
Author
Owner
Copy Link

I have changed it so that we also use vars for the mkdir and rm command.

I have changed it so that we also use vars for the mkdir and rm command.
sgode added 1 commit 2023-10-24 07:56:08 +00:00
Made tox.ini smaller
All checks were successful
gl/check check status: success (daa55049c77256d5e35ee945e902f3ff933e12ff)
Details
daa55049c7
zuul commented 2023-10-24 08:00:22 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/ad98a20dd62c4cdcae6df3370dbc6da3

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/ad98a20dd62c4cdcae6df3370dbc6da3 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/afe2a7db80a14932bb8fedda33c3e4cb): SUCCESS in 3m 32s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/7043295e2da848369b09ec2dc64c1a24): SUCCESS in 3m 46s
sgode added 1 commit 2023-10-24 09:03:36 +00:00
JSON changes
All checks were successful
gl/check check status: success (39afa1066296730e4efd9ade26add68a18ae4a20)
Details
gl/gate gate status: success (39afa1066296730e4efd9ade26add68a18ae4a20)
Details
39afa10662
zuul commented 2023-10-24 09:06:49 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/6cf51b2b11784bee814b4daebcb337fb

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/6cf51b2b11784bee814b4daebcb337fb - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/6466b95b006f48228c3c18797c93e528): SUCCESS in 2m 26s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/d73b4afa64424efc8c0b563c18ef187e): SUCCESS in 2m 49s
tischrei added the
gate
 label 2023-11-01 13:24:39 +00:00
tischrei requested review from tischrei 2023-11-01 13:26:36 +00:00
tischrei removed the
gate
 label 2023-11-01 13:26:49 +00:00
tischrei approved these changes 2023-11-01 13:26:52 +00:00
tischrei added the
gate
 label 2023-11-01 13:26:56 +00:00
zuul commented 2023-11-01 13:29:42 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/540329d1d5604f9088ac7bd386e820a9

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/540329d1d5604f9088ac7bd386e820a9 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/d4bfc092fd044e9285ee462181f9e0d6): SUCCESS in 2m 00s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/7e61745a5bb8448c8e78b7d5de9f8bd0): SUCCESS in 2m 25s
zuul merged commit 7bab061bd2 into main 2023-11-01 13:29:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
vhasko
tischrei
Labels
Clear labels
gate
Gate it
gate
Gate it
No Label
gate
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 ansideln cicd ikvrivis magnus otcbot proposalbot sgode smartyno tischrei vhasko vladimirhasko vladimirvshivkov vvshivko zuul
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#147
No description provided.
Delete Branch "minify-template-tox"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?