infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

Added sphinx-minify to tox #147

Merged
zuul merged 3 commits from minify-template-tox into main 2023-11-01 13:29:43 +00:00
Conversation 7 Commits 3 Files Changed 2 +8 -13
2 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit daa55049c7 - Show all commits

16
otc_metadata/templates/tox.ini.j2
View File

@ -68,19 +68,9 @@ allowlist_externals =
mkdir mkdir
commands = commands =
sphinx-build -W --keep-going -b html {{ loc }}/source doc/build/html_temp/{{ doc.type }} sphinx-build -W --keep-going -b html {{ loc }}/source doc/build/html_temp/{{ doc.type }}
{%- if doc.type == 'api-ref' %} sphinx-minify --input-directory doc/build/html_temp/{{ doc.type }} --output-directory doc/build/html/{{ doc.type }}
sphinx-minify --input-directory doc/build/html_temp/api-ref --output-directory doc/build/html/api-ref mkdir -p {{ doc.type }}/build/html
vhasko commented 2023-10-20 13:30:37 +00:00
Outdated
Review
Copy Link

in this case I don’t see any reason why you duplicating this entry in to 3 condition cases instead of putting it before condition and parametrizing it with doc.type like:

sphinx-minify --input-directory doc/build/html_temp/{{ doc.type }} --output-directory doc/build/html/{{ doc.type }}
in this case I don't see any reason why you duplicating this entry in to 3 condition cases instead of putting it before condition and parametrizing it with doc.type like: ``` sphinx-minify --input-directory doc/build/html_temp/{{ doc.type }} --output-directory doc/build/html/{{ doc.type }} ```
sgode commented 2023-10-24 07:57:00 +00:00
Outdated
Review
Copy Link

I have changed it so that we also use vars for the mkdir and rm command.

I have changed it so that we also use vars for the mkdir and rm command.
mkdir -p api-ref/build/html cp -av doc/build/html/{{ doc.type }} {{ doc.type }}/build/html
cp -av doc/build/html/api-ref api-ref/build/html
{%- elif doc.type == 'umn' %}
sphinx-minify --input-directory doc/build/html_temp/umn --output-directory doc/build/html/umn
mkdir -p umn/build/html
cp -av doc/build/html/umn umn/build/html
{%- elif doc.type == 'dev-guide' %}
sphinx-minify --input-directory doc/build/html_temp/dev-guide --output-directory doc/build/html/dev-guide
mkdir -p dev_guide/build/html
cp -av doc/build/html/dev-guide dev_guide/build/html
{%- endif %}
# Json version (for search) # Json version (for search)
[testenv:json-{{ doc.type }}] [testenv:json-{{ doc.type }}]