infra/otc-metadata
15
0
Fork 13
Code Issues 5 Pull Requests Packages Releases Wiki Activity

add get_service_with_docs_by_service_type() #35

Merged
zuul merged 2 commits from service_by_service_type into main 2023-02-21 10:44:52 +00:00
Conversation 5 Commits 2 Files Changed 1
+19
tischrei commented 2023-02-20 13:51:24 +00:00
Owner
Copy Link
Copy Source
tischrei added 1 commit 2023-02-20 13:51:25 +00:00
add get_service_with_docs_by_service_type()
gl/check check status: success (44320ea668c58f6f70db2aa50fdbaa689403ef87)
Details
44320ea668
zuul commented 2023-02-20 13:54:18 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/40839dd46402477e9783b92fc3fe3bbe

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/40839dd46402477e9783b92fc3fe3bbe - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/95137a8c217f44bf9c22be85168479e5): SUCCESS in 2m 13s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/3d2212cc112548fd90211bb764195caa): SUCCESS in 2m 29s
vhasko reviewed 2023-02-20 18:26:02 +00:00
otc_metadata/services.py
@@ -212,0 +226,4 @@
for service in services['services']:
if service['service_type'] == service_type:
res['service'] = service
break
vhasko commented 2023-02-20 18:26:02 +00:00
Owner
Copy Link
Copy Source

why break is required here? There’s only unique service_type in services so after the if condition for the matching service_type you should get exactly one matching res[‘service’] even after completing the loop.

why break is required here? There's only unique service_type in services so after the if condition for the matching service_type you should get exactly one matching res['service'] even after completing the loop.
tischrei commented 2023-02-21 08:37:33 +00:00
Author
Owner
Copy Link
Copy Source

You are right, that the break is not necessary. The reason I use it here is to shorten the runtime a bit. The loop breaks because 1 result is expected, otherwise the loop would run further which is not necessary and results in larger runtime of this loop.

You are right, that the break is not necessary. The reason I use it here is to shorten the runtime a bit. The loop breaks because 1 result is expected, otherwise the loop would run further which is not necessary and results in larger runtime of this loop.
tischrei marked this conversation as resolved
tischrei added 1 commit 2023-02-21 10:36:25 +00:00
minor change
gl/check check status: success (bf1f3f7afe1d1015e70d17921d88d563ba438ce5)
Details
gl/gate gate status: success (bf1f3f7afe1d1015e70d17921d88d563ba438ce5)
Details
bf1f3f7afe
vhasko approved these changes 2023-02-21 10:37:00 +00:00
zuul commented 2023-02-21 10:39:28 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/bfe27bd4fd7e4ce2bb866ac37b110d99

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/bfe27bd4fd7e4ce2bb866ac37b110d99 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/2f610d5a79cb482eb4fa089bf3d44c11): SUCCESS in 2m 20s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/3986eece1bd54f2b91408459e0ee646b): SUCCESS in 2m 42s
tischrei added the gate label 2023-02-21 10:41:35 +00:00
zuul commented 2023-02-21 10:44:51 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/4dac254a5b4747a6b878c80f47355f28

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/4dac254a5b4747a6b878c80f47355f28 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/7fc8515112d84aaabb0444f57375209f): SUCCESS in 2m 24s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/c11eb08c6b804ab5bae3f4b4ddbf5b5e): SUCCESS in 2m 54s
zuul merged commit 8de5c8ba57 into main 2023-02-21 10:44:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
vhasko
Labels
Clear labels
gate
Gate it
gate
Gate it
No labels gate
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 (Lukas Cuper,) akyriako (Akriotis, Kyriakos) ansideln (Sidelnikov, Anton) cicd eod ikvrivis (Kvrivishvili, Iustina) otcbot proposalbot sgode (Gode, Sebastian) smartyno (Martynov, Sergei) tischrei (Tino Schreiber) vhasko (Hasko, Vladimir) vladimirhasko zuul zuul-ci
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#35